Adar Dembo has posted comments on this change. Change subject: log block manager: use extent maps to decide whether to truncate containers ......................................................................
Patch Set 7: > > Right, we talked about this before. Assuming an "expensive > repair" thing exists, the issue isn't knowing _when_ to > re-hole-punch; it's knowing _how much_ unpunched space exists (for > reporting purposes), and this approach doesn't provide an accurate > measure of that. > > Still missing something. Isn't that stat.st_blocks * > stat.st_blksize - expected_size? If we're considering just unpunched holes, then yes. But, if the container also has space beyond the file size (i.e. both unpunched holes and extra preallocated space), then we don't know to which inconsistency to attribute the excess. -- To view, visit http://gerrit.cloudera.org:8080/6585 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3541f70721328d5af911f4889f8b4bcf0de3ebf8 Gerrit-PatchSet: 7 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: David Ribeiro Alves <dral...@apache.org> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-HasComments: No
