Dan Burkert has posted comments on this change. Change subject: KUDU-861 Support changing column defaults and storage attributes ......................................................................
Patch Set 1: (4 comments) http://gerrit.cloudera.org:8080/#/c/6725/1/src/kudu/client/table_alterer-internal.cc File src/kudu/client/table_alterer-internal.cc: Line 122: auto *alter_pb = pb_step->mutable_alter_column(); * with the type http://gerrit.cloudera.org:8080/#/c/6725/1/src/kudu/client/value.cc File src/kudu/client/value.cc: PS1, Line 194: uint8_t * uint8_t* http://gerrit.cloudera.org:8080/#/c/6725/1/src/kudu/integration-tests/alter_table-randomized-test.cc File src/kudu/integration-tests/alter_table-randomized-test.cc: Line 271: void RenameColumn(const string& existing_name, const string& new_name) { There are a few callers which are moving the new_name into this method. Additionally it shouldn't be moving it internally either. Line 432: int r = ts_.rand_.Uniform(6); This needs to be incremented to 9 -- To view, visit http://gerrit.cloudera.org:8080/6725 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I48dcfd1ced488943c3da1eb0a26f62780ac9214f Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Will Berkeley <wdberke...@gmail.com> Gerrit-Reviewer: Dan Burkert <danburk...@apache.org> Gerrit-Reviewer: Jean-Daniel Cryans <jdcry...@apache.org> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Tidy Bot Gerrit-HasComments: Yes
