Hello David Ribeiro Alves, Todd Lipcon, I'd like you to do a code review. Please visit
http://gerrit.cloudera.org:8080/6740 to review the following change. Change subject: subprocess: remove progname argument ...................................................................... subprocess: remove progname argument When constructing a subprocess, 'argv[0]' always duplicates 'program', and is typically BaseName()'d as well. Let's just codify that in the subprocess code so that callers need not worry about it. Change-Id: I42d3cb551c350d8f10308035084a8807a1ae240b --- M src/kudu/benchmarks/tpch/tpch_real_world.cc M src/kudu/integration-tests/external_mini_cluster.cc M src/kudu/integration-tests/full_stack-insert-scan-test.cc M src/kudu/rpc/rpc_stub-test.cc M src/kudu/security/test/mini_kdc.cc M src/kudu/util/pstack_watcher.cc M src/kudu/util/pstack_watcher.h M src/kudu/util/subprocess-test.cc M src/kudu/util/subprocess.cc M src/kudu/util/subprocess.h 10 files changed, 33 insertions(+), 46 deletions(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/40/6740/1 -- To view, visit http://gerrit.cloudera.org:8080/6740 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I42d3cb551c350d8f10308035084a8807a1ae240b Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: David Ribeiro Alves <davidral...@gmail.com> Gerrit-Reviewer: Todd Lipcon <t...@apache.org>