Jean-Daniel Cryans has posted comments on this change.

Change subject: mapreduce: add support for fault tolerant scanner
......................................................................


Patch Set 2:

The test failure is related to the fault tolerant scanner patch:
01:09:34.954 [INFO - kudu-tserver:64040] (MiniKuduCluster.java:568) W0428 
01:09:34.954133 17141 connection.cc:380] Connection torn down before Call 
kudu.tserver.TabletServerService.Write from 127.0.0.1:35554 (ReqId={client: 
21809ecd299e454fa1a5ce2dcc9d4faf, seq_no=16347, attempt_no=1}) could send its 
response
01:09:34.954 [ERROR - Thread-10] (ITClient.java:134) Got error while row 
counting
org.apache.kudu.client.RecoverableException: [Peer 
7605e33bc78748a08bd01815dd8aff56] Connection disconnected
        at org.apache.kudu.client.TabletClient.cleanup(TabletClient.java:657)
        at 
org.apache.kudu.client.TabletClient.channelDisconnected(TabletClient.java:610)
        at 
org.jboss.netty.channel.SimpleChannelUpstreamHandler.handleUpstream(SimpleChannelUpstreamHandler.java:102)
        at 
org.apache.kudu.client.TabletClient.handleUpstream(TabletClient.java:603)
        at 
org.jboss.netty.channel.DefaultChannelPipeline.sendUpstream(DefaultChannelPipeline.java:564)

What this means is that the connection got closed before the scan was sent. I 
think this should be a retryable exception even for non-fault tolerant 
scanners? Maybe it would make more sense to make ITClient use fault tolerant 
scanners too.

-- 
To view, visit http://gerrit.cloudera.org:8080/6745
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ibc39472e2733bab4e00e73658f8a7619153bd7c6
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Hao Hao <hao....@cloudera.com>
Gerrit-Reviewer: Jean-Daniel Cryans <jdcry...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-HasComments: No

Reply via email to