Alexey Serbin has posted comments on this change. Change subject: tablet copy: Ensure no data loss on tablet copy failure ......................................................................
Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/6732/2/src/kudu/integration-tests/tablet_copy-itest.cc File src/kudu/integration-tests/tablet_copy-itest.cc: PS2, Line 987: : INSTANTIATE_TEST_CASE_P(FaultFlags, BadTabletCopyITest, : ::testing::ValuesIn(tablet_copy_failure_flags)); : : // This test uses CountBlocksUnderManagement() which only works with the : // LogBlockManager. : #ifndef __APPLE__ : : // Ensure that a tablet copy failure results in no orphaned blocks and no data loss. : TEST_P(BadTabletCopyITest, TestBadCopy) { > There is a comment above the #ifdef to explain why it's there. However I ca Uh-oh, somehow I missed that, sorry. Yep, if that test is not to be run on OS X, may be it's worth if-deffing everything else around related to it. -- To view, visit http://gerrit.cloudera.org:8080/6732 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie57590e2473e09a6836bb02d5fccb7689614f8e7 Gerrit-PatchSet: 2 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Mike Percy <mpe...@apache.org> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy <mpe...@apache.org> Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-HasComments: Yes
