Adar Dembo has posted comments on this change. Change subject: [KUDU-754] add an environment variable for kudu client debugging to stderr ......................................................................
Patch Set 4: (4 comments) Looks good, thanks for the contribution! Just passing through with a couple style nits. http://gerrit.cloudera.org:8080/#/c/6736/4//COMMIT_MSG Commit Message: PS4, Line 11: Initi Nit: Init http://gerrit.cloudera.org:8080/#/c/6736/4/src/kudu/client/client.cc File src/kudu/client/client.cc: Line 60: #include "kudu/gutil/strings/numbers.h" Nit: should come before substitute.h (alphabetical sorting). PS4, Line 153: >=0 Nit: separate >= from 0 with a space. PS4, Line 156: << "." Nit: no need to terminate LOG messages with a period. -- To view, visit http://gerrit.cloudera.org:8080/6736 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iab5c7c24395c25184489200283dd38da024c07bb Gerrit-PatchSet: 4 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: William Li <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Cam Mach <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-Reviewer: William Li <[email protected]> Gerrit-HasComments: Yes
