Adar Dembo has submitted this change and it was merged. Change subject: log_block_manager: refactor container record processing ......................................................................
log_block_manager: refactor container record processing While working on some other LBM stuff I noticed that LogBlockManager::ProcessBlockRecord() was effectively static; this patch moves it into the LogBlockContainer. Besides narrowing the function's scope, we can now process records as they are read rather than storing them in a deque to be processed later. To make this refactor work, I had to move the LogBlock definition so that LogBlockContainer could use it. This also means various LogBlockContainer methods can now take LogBlock-typed arguments, and GetAlignedBlockLength() can move over to LogBlock where it belongs. Change-Id: I5b8da74dc699f4afbeda41ee154eb1ba89dac292 Reviewed-on: http://gerrit.cloudera.org:8080/6769 Tested-by: Adar Dembo <a...@cloudera.com> Reviewed-by: David Ribeiro Alves <davidral...@gmail.com> --- M src/kudu/fs/log_block_manager.cc M src/kudu/fs/log_block_manager.h 2 files changed, 238 insertions(+), 241 deletions(-) Approvals: David Ribeiro Alves: Looks good to me, approved Adar Dembo: Verified -- To view, visit http://gerrit.cloudera.org:8080/6769 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: merged Gerrit-Change-Id: I5b8da74dc699f4afbeda41ee154eb1ba89dac292 Gerrit-PatchSet: 4 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: David Ribeiro Alves <davidral...@gmail.com> Gerrit-Reviewer: Todd Lipcon <t...@apache.org>
