David Ribeiro Alves has submitted this change and it was merged. Change subject: [flaky tests] Address LSAN false positives ......................................................................
[flaky tests] Address LSAN false positives Some tests, like external_mini_cluster-itest, are now only failing in ASAN due to leaks. Upon inspection I could only find false positives among these leaks around thread local variables. This seems related to this issue: https://github.com/google/sanitizers/issues/757 The fix is to wrap those specific instances of false positives with ScopedLeakDisabler so that they don't get reported. After many tries I was unable to come up with the right incantation to cause this in dist-tests. Running the highest failing test in ASAN with stress was not enough to cause this. Somehow this is more likely in jenkins where these failures are pretty common. Change-Id: I8c8d9ff83c0cfbc11cab213a25cbd5daa3b25869 Reviewed-on: http://gerrit.cloudera.org:8080/6320 Reviewed-by: David Ribeiro Alves <davidral...@gmail.com> Tested-by: Kudu Jenkins --- M src/kudu/util/kernel_stack_watchdog.cc M src/kudu/util/thread_restrictions.cc 2 files changed, 8 insertions(+), 0 deletions(-) Approvals: David Ribeiro Alves: Looks good to me, approved Kudu Jenkins: Verified -- To view, visit http://gerrit.cloudera.org:8080/6320 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: merged Gerrit-Change-Id: I8c8d9ff83c0cfbc11cab213a25cbd5daa3b25869 Gerrit-PatchSet: 5 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: David Ribeiro Alves <davidral...@gmail.com> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com> Gerrit-Reviewer: David Ribeiro Alves <davidral...@gmail.com> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon <t...@apache.org>
