Todd Lipcon has posted comments on this change. Change subject: [util] use emplace() instead of insert() ......................................................................
Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/6807/1/src/kudu/gutil/map-util.h File src/kudu/gutil/map-util.h: Line 364: pair<typename Collection::iterator, bool> ret = collection->emplace(key, value); don't we need to change 'key' and 'value' above to be by-value and then use std::move here? Otherwise it's still going to be calling the copy constructor instead of an available move constructor -- To view, visit http://gerrit.cloudera.org:8080/6807 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic40b17d9315d7c42d589fd30ce55242540e7767f Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-HasComments: Yes
