Alexey Serbin has posted comments on this change. Change subject: cert: add check for pending SSL errors in cert-related code ......................................................................
Patch Set 1: (3 comments) http://gerrit.cloudera.org:8080/#/c/6814/1/src/kudu/security/cert.cc File src/kudu/security/cert.cc: Line 139: OPENSSL_RET_NOT_OK(X509_check_private_key(data_.get(), key.GetRawData()), Would it make sense to add SCOPED_OPENSSL_NO_PENDING errors here as well? Line 212: EVP_PKEY* raw_key = X509_get_pubkey(data_.get()); Ditto? Line 240: EVP_PKEY* raw_key = X509_REQ_get_pubkey(data_.get()); ditto? -- To view, visit http://gerrit.cloudera.org:8080/6814 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I94bb6b71926051d2f8a7eabaa1eceb048ea9ec30 Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Todd Lipcon <t...@apache.org> Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Kudu Jenkins Gerrit-HasComments: Yes
