Todd Lipcon has posted comments on this change. Change subject: WIP: release WritableLogSegment buffers when log is idle ......................................................................
Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/6611/2/src/kudu/consensus/log.cc File src/kudu/consensus/log.cc: PS2, Line 224: // TODO(todd): consider rolling to a non-preallocated segment if we are : // idle for a good period of time (eg a few minutes), so that startup time is : // improved and disk usage is minimized. > I forget, do all of you memstores get flushed in a time basis, no matter ho yes, I believe so. -- To view, visit http://gerrit.cloudera.org:8080/6611 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I512c7f9264ac9490e6a57259e4d7b2608adc1ca7 Gerrit-PatchSet: 2 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Todd Lipcon <t...@apache.org> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: David Ribeiro Alves <davidral...@gmail.com> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-HasComments: Yes