Dan Burkert has posted comments on this change. Change subject: spark: add support for fault tolerant scanner ......................................................................
Patch Set 5: (1 comment) http://gerrit.cloudera.org:8080/#/c/6782/5/java/kudu-spark/src/main/scala/org/apache/kudu/spark/kudu/DefaultSource.scala File java/kudu-spark/src/main/scala/org/apache/kudu/spark/kudu/DefaultSource.scala: Line 50: val FAULT_TOLERANT_SCANNER = "kudu.fault.tolerant.scan" > hmm should this be something like 'kudu.fault-tolerant-scan'? I typically looks like the normal thing to do with spark options is camel case, so this should be "kudu.faultToleranScan". exampls: https://spark.apache.org/docs/latest/monitoring.html -- To view, visit http://gerrit.cloudera.org:8080/6782 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3f3192025ca5d74197600480fd3d040d70b4bbc2 Gerrit-PatchSet: 5 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Hao Hao <hao....@cloudera.com> Gerrit-Reviewer: Dan Burkert <danburk...@apache.org> Gerrit-Reviewer: Hao Hao <hao....@cloudera.com> Gerrit-Reviewer: Jean-Daniel Cryans <jdcry...@apache.org> Gerrit-Reviewer: Kudu Jenkins Gerrit-HasComments: Yes
