Hao Hao has posted comments on this change. Change subject: KUDU-1875: Refuse unauthenticated connections from publicly routable IP addrs ......................................................................
Patch Set 18: (8 comments) http://gerrit.cloudera.org:8080/#/c/6514/17/src/kudu/rpc/server_negotiation.cc File src/kudu/rpc/server_negotiation.cc: Line 873: for (const auto const& t : strings::Split(FLAGS_trusted_subnets, ",", strings::SkipEmpty())) { > warning: the variable '__end' is copy-constructed from a const reference bu Done http://gerrit.cloudera.org:8080/#/c/6514/17/src/kudu/security/init.cc File src/kudu/security/init.cc: Line 69: > warning: the variable '__end' is copy-constructed from a const reference bu Done http://gerrit.cloudera.org:8080/#/c/6514/17/src/kudu/util/net/net_util.cc File src/kudu/util/net/net_util.cc: Line 230: Sockaddr addr(*reinterpret_cast<struct sockaddr_in*>(ifa->ifa_addr)); > warning: C-style casts are discouraged; use reinterpret_cast [google-readab Done Line 231: Sockaddr netmask(*reinterpret_cast<struct sockaddr_in*>(ifa->ifa_netmask)); > warning: C-style casts are discouraged; use reinterpret_cast [google-readab Done http://gerrit.cloudera.org:8080/#/c/6514/17/src/kudu/util/net/net_util.h File src/kudu/util/net/net_util.h: Line 114: Status GetFQDN(std::string* hostname); > warning: function 'kudu::GetFQDN' has a definition with different parameter Done http://gerrit.cloudera.org:8080/#/c/6514/13/src/kudu/util/net/sockaddr.cc File src/kudu/util/net/sockaddr.cc: Line 120: > warning: redundant boolean literal in conditional return statement [readabi Done Line 121: // Strip any whitespace from the cidr_addr. > warning: don't use else after return [readability-else-after-return] Done http://gerrit.cloudera.org:8080/#/c/6514/14/src/kudu/util/net/sockaddr.h File src/kudu/util/net/sockaddr.h: Line 71: bool WithInSubnet(const std::string& net_cidr_addr) const; > warning: function 'kudu::Sockaddr::WithInSubnet' has a definition with diff Done -- To view, visit http://gerrit.cloudera.org:8080/6514 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6c3fbb5491785874c5701d6c9d866949cfac905e Gerrit-PatchSet: 18 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Hao Hao <hao....@cloudera.com> Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Dan Burkert <danburk...@apache.org> Gerrit-Reviewer: Hao Hao <hao....@cloudera.com> Gerrit-Reviewer: Harsh J <ha...@harshj.com> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-HasComments: Yes
