Mike Percy has posted comments on this change. Change subject: Refactor ConsensusStatePB to hold committed and pending configs ......................................................................
Patch Set 2: (5 comments) http://gerrit.cloudera.org:8080/#/c/6809/2/src/kudu/consensus/metadata.proto File src/kudu/consensus/metadata.proto: PS2, Line 113: leader_uuid I think this is a little confusing. Can this just be the current leader, and if it's not part of the committed config then the master will have to figure that out? PS2, Line 117: config Rename to committed_config; Protobuf allows you to rename things as long as the position doesn't change. PS2, Line 121: pending_leader_uuid I'm not sure why this needs to be specified separately. I think we should remove this field. http://gerrit.cloudera.org:8080/#/c/6809/2/src/kudu/tserver/tablet_copy_source_session.cc File src/kudu/tserver/tablet_copy_source_session.cc: PS2, Line 131: initial_committed_cstate_ Rename to initial_cstate_ http://gerrit.cloudera.org:8080/#/c/6809/2/src/kudu/tserver/ts_tablet_manager.cc File src/kudu/tserver/ts_tablet_manager.cc: PS2, Line 951: committed_consensus_state Rename to consensus_state -- To view, visit http://gerrit.cloudera.org:8080/6809 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4bc4bdd9752fc29a7ce2cefcdc95c4366f5353af Gerrit-PatchSet: 2 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Will Berkeley <wdberke...@gmail.com> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy <mpe...@apache.org> Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Will Berkeley <wdberke...@gmail.com> Gerrit-HasComments: Yes
