David Ribeiro Alves has posted comments on this change. Change subject: KUDU-1549: delete dead LBM containers at startup ......................................................................
Patch Set 1: (3 comments) http://gerrit.cloudera.org:8080/#/c/6824/1//COMMIT_MSG Commit Message: PS1, Line 11: we lose some forensic information in doing so such as? I mean it'd be good for this message to spell out the rough types/uses of the lost info PS1, Line 15: It would be nice to also do it in real time (perhaps as a : maintenance manager operation), but that requires containers to have shared : ownership, a lifecycle change I'm not keen on making right now. getting a bit worried that doing proper LBM maintenance will depend on restarting a server. Not a concern of this patch per se, but something to keep in mind. Likely most users are not expecting to restart the cluster except for the very occasional upgrade. http://gerrit.cloudera.org:8080/#/c/6824/1/src/kudu/fs/log_block_manager.cc File src/kudu/fs/log_block_manager.cc: Line 1677: CHECK(to_delete->full()); add an error message. -- To view, visit http://gerrit.cloudera.org:8080/6824 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I73a903092cf89508b7ba97fde3a2d6e691161b4c Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Adar Dembo <[email protected]> Gerrit-Reviewer: David Ribeiro Alves <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-HasComments: Yes
