Adar Dembo has posted comments on this change.

Change subject: fs_manager: optimize tmp file deletion
......................................................................


Patch Set 1:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/6837/1/src/kudu/fs/fs_manager.cc
File src/kudu/fs/fs_manager.cc:

PS1, Line 239: code:
             :   //
             :   //   Status s = fs_manager_->Open();
             :   //   if (s.IsNotFound()) {
             :   //     
RETURN_NOT_OK(fs_manager_->CreateInitialFileSystemLayout());
             :   //     s = fs_manager_->Open();
             :   //   }
             :   //   RETURN_NOT_OK(s);
> I think instead of putting this code snippet here, you could just say "mini
Done


-- 
To view, visit http://gerrit.cloudera.org:8080/6837
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I07830f0cc3fd5da847361607c62a369c39e677d2
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Adar Dembo <a...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <a...@cloudera.com>
Gerrit-Reviewer: David Ribeiro Alves <davidral...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <t...@apache.org>
Gerrit-HasComments: Yes

Reply via email to