Mike Percy has posted comments on this change. Change subject: Refactor ConsensusStatePB to hold committed and pending configs ......................................................................
Patch Set 8: (4 comments) I only took a quick look at rev 8; there are a bunch of review comments missed in rev 8 marked as done in rev 6 so I think a rebase got messed up or something. http://gerrit.cloudera.org:8080/#/c/6809/6/src/kudu/consensus/metadata.proto File src/kudu/consensus/metadata.proto: PS6, Line 103: There is a corner case in Raft where a node may be elected leader of a : // pending (uncommitted) configuration. In such a case, the master will : // detect that the node is not a member of the committed configuration. > Done Not done yet in rev 8 PS6, Line 113: 5 > Done Not done in rev 8 http://gerrit.cloudera.org:8080/#/c/6809/8/src/kudu/consensus/quorum_util.cc File src/kudu/consensus/quorum_util.cc: PS8, Line 197: return Status::IllegalState( : Substitute("Leader with UUID $0 is not a VOTER in the committed or pending config! " : "Consensus state: $1", > hrm, isn't this possible? eg when catching up a node that is more than one I actually don't think it's possible to hit this in the current production code because we run this right after the consensus meta is loaded from disk. However I talked to Will about this offline and suggested he define a different function to call from sys_catalog.cc and then we can leave this one for use by tests. Line 304: Substitute("term changed from $0 to $1", nit: 4 line indentation for a continued line per https://google.github.io/styleguide/cppguide.html#Function_Calls -- To view, visit http://gerrit.cloudera.org:8080/6809 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4bc4bdd9752fc29a7ce2cefcdc95c4366f5353af Gerrit-PatchSet: 8 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Will Berkeley <wdberke...@gmail.com> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy <mpe...@apache.org> Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-Reviewer: Will Berkeley <wdberke...@gmail.com> Gerrit-HasComments: Yes
