Will Berkeley has posted comments on this change. Change subject: KUDU-2001 Add UNDO size to tablet on-disk size ......................................................................
Patch Set 3: (5 comments) http://gerrit.cloudera.org:8080/#/c/6850/3/src/kudu/tablet/delta_tracker.h File src/kudu/tablet/delta_tracker.h: PS3, Line 219: . > of all delta blocks. Done PS3, Line 222: eligible for compaction. : // This estimate includes REDO deltas, but not UNDO deltas > of REDO deltas Done PS3, Line 224: EstimateOnDiskSizeForCompaction > Rename to EstimateRedoDeltaOnDiskSize() Done http://gerrit.cloudera.org:8080/#/c/6850/3/src/kudu/tablet/diskrowset.h File src/kudu/tablet/diskrowset.h: PS3, Line 336: EstimateDeltaDiskSizeForCompaction > I think a better name would be EstimateRedoDeltaDiskSize() Done Line 339: // TODO(wdberkeley) Offer a version that has the real total disk space usage. > Add: See KUDU-1755. Done -- To view, visit http://gerrit.cloudera.org:8080/6850 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I59001adadb9a768a464e7b2cf0f0a5df0ef5393a Gerrit-PatchSet: 3 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Will Berkeley <wdberke...@gmail.com> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy <mpe...@apache.org> Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Will Berkeley <wdberke...@gmail.com> Gerrit-HasComments: Yes
