Todd Lipcon has posted comments on this change. Change subject: block manager: require file cache ......................................................................
Patch Set 2: Code-Review+2 (1 comment) http://gerrit.cloudera.org:8080/#/c/6880/1/src/kudu/fs/block_manager.cc File src/kudu/fs/block_manager.cc: PS1, Line 48: if (value == 0) { : LOG(ERROR) << "Invalid max open files: cannot be 0"; : return false; : } : return true; > Dan asked me that when I was first committing the file cache code. Specific sounds good -- To view, visit http://gerrit.cloudera.org:8080/6880 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9946e537e0b4abd66a9a90fc05df04232db68bc0 Gerrit-PatchSet: 2 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-HasComments: Yes
