Hello Mike Percy, Will Berkeley,
I'd like you to do a code review. Please visit
http://gerrit.cloudera.org:8080/6913
to review the following change.
Change subject: Improve logging during server startup
......................................................................
Improve logging during server startup
This makes a few improvements to the log output during startup,
particularly helpful when there are lots of tablets:
- Only show progress reports of loading tablet metadata once a second,
with an indication of progress, rather than logging one line per
tablet.
- In the common case of reading a log which ends on a log entry
boundary, with all following data being preallocated space (all 0
bytes), don't log anything with the word "corruption" in it, to avoid
scaring users.
- Only log timing of Tablet::Open() when slow (>100ms)
- Bump various fine-grained details about tablet startup to VLOG(1)
level instead of LOG(INFO)
Change-Id: Ia5e597dfd08d5cf0cbbfe2c5ef532ffba9d113d7
---
M src/kudu/consensus/log_reader.cc
M src/kudu/consensus/log_util.cc
M src/kudu/consensus/log_util.h
M src/kudu/tablet/tablet.cc
M src/kudu/tablet/tablet_bootstrap-test.cc
M src/kudu/tablet/tablet_bootstrap.cc
M src/kudu/tserver/ts_tablet_manager.cc
7 files changed, 126 insertions(+), 50 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/13/6913/1
--
To view, visit http://gerrit.cloudera.org:8080/6913
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ia5e597dfd08d5cf0cbbfe2c5ef532ffba9d113d7
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Todd Lipcon <t...@apache.org>
Gerrit-Reviewer: Mike Percy <mpe...@apache.org>
Gerrit-Reviewer: Will Berkeley <wdberke...@gmail.com>
