Todd Lipcon has posted comments on this change. Change subject: log: reduce segment size from 64MB to 8MB ......................................................................
Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/6911/1//COMMIT_MSG Commit Message: PS1, Line 7: 64MB to 8MB > Is it possible for a single Write RPC to exceed 8 MB? If so, does this chan it is possible, but I think based on the rolling code it should be fine -- we'll trigger a roll when we see that the current batch doesn't fit, but it doesn't loop or anything. So, I think you should end up with one batch per segment, which is more or less what we want. There's some possibility we end up with alternating empty segments and one-batch segments. We do have a number of tests which were already setting to 1MB roll threshold, but let me double check that we have one that also sends large batches. -- To view, visit http://gerrit.cloudera.org:8080/6911 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iadcda6b085e69cae5a15d54bb4c945d7605d5f98 Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Todd Lipcon <t...@apache.org> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: David Ribeiro Alves <davidral...@gmail.com> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy <mpe...@apache.org> Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-HasComments: Yes
