Todd Lipcon has posted comments on this change. Change subject: process_memory: go back to non-incremental tracking ......................................................................
Patch Set 1: (3 comments) http://gerrit.cloudera.org:8080/#/c/6915/1//COMMIT_MSG Commit Message: PS1, Line 34: noticeably better > Can you quantify that? takes a long time to run, so I didn't wait for the whole thing to finish :) Here's the plot I looked at, though: https://imagebin.ca/v/3Mq0VwvSGSJ1 http://gerrit.cloudera.org:8080/#/c/6915/1/src/kudu/util/process_memory.cc File src/kudu/util/process_memory.cc: Line 191: const int64_t kReadIntervalMicros = 50000; > I'm curious as to how you arrived at this number. My instinct would be to g figured that we would have a hard time using more than a few MB in 50ms, and it would definitely avoid contention? PS1, Line 198: GetMonoTimeMicros() > Shouldn't this be 'time'? I wanted to re-fetch time, so that we guarantee the sleep _between_ calls is at least 50ms. That way, if the call itself started being slow (eg because we have 10000 threads) we guarantee some progress -- To view, visit http://gerrit.cloudera.org:8080/6915 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8823028de3ea260f1450d9bf34af2dc5a794b206 Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Todd Lipcon <t...@apache.org> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-HasComments: Yes
