Todd Lipcon has posted comments on this change. Change subject: KUDU-1952 Remove round-robin for block placement ......................................................................
Patch Set 35: (5 comments) http://gerrit.cloudera.org:8080/#/c/6636/35/src/kudu/fs/block_manager-test.cc File src/kudu/fs/block_manager-test.cc: PS35, Line 249: nuber nit: number http://gerrit.cloudera.org:8080/#/c/6636/35/src/kudu/fs/data_dirs-test.cc File src/kudu/fs/data_dirs-test.cc: PS35, Line 161: // Looping this 1000 times with an assertion of 2.0 resulted in a couple failures. : // Asserting 3.0 should give a safe non-flaky buffer. : ASSERT_LE(stddev, 3.0); > think we're setting ourselves up for flakyness here, unfortunately it's har hm, yea, if the distribution were normal, then a z-score of 3 would be only 99.7%. But I don't think it produces a normal distribution (not sure what kind of distribution it produces). That said, I'm OK if we've looped it thousands of times and found this works. http://gerrit.cloudera.org:8080/#/c/6636/35/src/kudu/fs/data_dirs.cc File src/kudu/fs/data_dirs.cc: PS35, Line 435: exists here and below, I sort of feel like "exists" is not the right word, but rather "registered" or somesuch? PS35, Line 478: // Lock shared to not block other reads to group_by_tablet_map_. this is kinda redundant with the code PS35, Line 504: RETURN_NOT_OK(candidate->RefreshIsFull( : DataDir::RefreshMode::EXPIRED_ONLY)); nit: no need to wrap -- To view, visit http://gerrit.cloudera.org:8080/6636 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9828147f4fa5c4d7f6ed23441dca5a116b8cb11b Gerrit-PatchSet: 35 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Andrew Wong <aw...@cloudera.com> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com> Gerrit-Reviewer: David Ribeiro Alves <davidral...@gmail.com> Gerrit-Reviewer: Jean-Daniel Cryans <jdcry...@apache.org> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-HasComments: Yes
