Mike Percy has posted comments on this change. Change subject: Fix flaky test TestRestartWithOrphanedReplicates ......................................................................
Patch Set 2: Code-Review+1 (3 comments) Change looks good, I have a few nitpicky comments about, well, comments. http://gerrit.cloudera.org:8080/#/c/6976/2/src/kudu/integration-tests/ts_recovery-itest.cc File src/kudu/integration-tests/ts_recovery-itest.cc: Line 97: // 1. Setup I don't think this comment really adds any value to this test. Line 108: cluster_->SetFlag(cluster_->tablet_server(0), I think a better comment here would be: // Crash when the WAL contains a replicate message but no corresponding commit. Line 121: // 3. Validate I think a better comment here would be: // Restart the server and check to make sure that the change is eventually applied. -- To view, visit http://gerrit.cloudera.org:8080/6976 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ied9a55abd20841d350589ce56aa935ea1feece79 Gerrit-PatchSet: 2 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Edward Fancher <e...@cloudera.com> Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy <mpe...@apache.org> Gerrit-HasComments: Yes
