Alexey Serbin has posted comments on this change. Change subject: KUDU-2021 test for negotiation timeout on Master RPCs ......................................................................
Patch Set 10: (1 comment) http://gerrit.cloudera.org:8080/#/c/6927/10/src/kudu/integration-tests/client-negotiation-failover-itest.cc File src/kudu/integration-tests/client-negotiation-failover-itest.cc: Line 257: SleepFor(MonoDelta::FromMilliseconds(FLAGS_rpc_negotiation_timeout_ms)); > can we add a few ms to this sleep? say 50ms We could, but what is the idea? The rpc timeout is set to twice that number. -- To view, visit http://gerrit.cloudera.org:8080/6927 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ib62126c9d8c6c65f447c5d03a0377eaff823393c Gerrit-PatchSet: 10 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy <mpe...@apache.org> Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-HasComments: Yes
