Alexey Serbin has posted comments on this change. Change subject: consensus: Get rid of LockFor*() methods ......................................................................
Patch Set 12: Code-Review+2 (3 comments) LGTM. You might be interested to get more feedback from Todd. http://gerrit.cloudera.org:8080/#/c/7012/10/src/kudu/consensus/raft_consensus.cc File src/kudu/consensus/raft_consensus.cc: PS10, Line 284: << State_Name(st > Done agreed -- it's better to make small verifiable steps PS10, Line 2120: UniqueLock > We need to unlock() below at L2178 woops, I missed that. http://gerrit.cloudera.org:8080/#/c/7012/10/src/kudu/consensus/raft_consensus.h File src/kudu/consensus/raft_consensus.h: PS10, Line 225: using UniqueLock = std::unique_lock<simple_spinlock>; > see my reply on the other comment Yep, thanks -- it seems I missed the unlock() part. -- To view, visit http://gerrit.cloudera.org:8080/7012 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6858752f4fbeb70b09eb4375c52e4aeaa1bb8e71 Gerrit-PatchSet: 12 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Mike Percy <mpe...@apache.org> Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: David Ribeiro Alves <davidral...@gmail.com> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy <mpe...@apache.org> Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-HasComments: Yes
