Todd Lipcon has posted comments on this change. Change subject: Add a workaround for LSAN bug #757 ......................................................................
Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/7052/1/src/kudu/server/generic_service.cc File src/kudu/server/generic_service.cc: PS1, Line 136: has_leaks = __lsan_do_recoverable_leak_check(); > LOG(WARN) when a leak is found but we're retrying? could we print the leak lsan_do_recoverable_leak_check already does print the leak to stderr. I suppose we could log the retries but is that useful on top of also logging the leaks? -- To view, visit http://gerrit.cloudera.org:8080/7052 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id79e4ed7fa6311bcabdb55b8d4fff9f9a4f242bc Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Todd Lipcon <t...@apache.org> Gerrit-Reviewer: David Ribeiro Alves <davidral...@gmail.com> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy <mpe...@apache.org> Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-HasComments: Yes