Dan Burkert has posted comments on this change. Change subject: Bump LLVM to 4.0.0 ......................................................................
Patch Set 1: (5 comments) http://gerrit.cloudera.org:8080/#/c/7069/1//COMMIT_MSG Commit Message: Line 7: Bump LLVM to 4.0.0 > Can you explain why you want to do this? I mean, it's generally a reasonabl Done http://gerrit.cloudera.org:8080/#/c/7069/1/thirdparty/package-llvm.sh File thirdparty/package-llvm.sh: Line 1: #!/bin/bash > Add copyright notice and a brief header explaining what this does. Done Line 5: VERSION=4.0.0 > Make this settable via variable. Something like: Done Line 8: do > Nit: move this to the previous line and separate with a semicolon; I think Done http://gerrit.cloudera.org:8080/#/c/7069/1/thirdparty/vars.sh File thirdparty/vars.sh: PS1, Line 134: # Summary: : # 1. Unpack the llvm tarball : # 2. Unpack the clang tarball as tools/clang (rename from cfe-<version> to clang) : # 3. Unpack the extra clang tools tarball as tools/clang/tools/extra : # 4. Unpack the lld tarball as tools/lld : # 5. Unpack the compiler-rt tarball as projects/compiler-rt : # 6. Unpack the libc++ tarball as projects/libcxx : # 7. Unpack the libc++abi tarball as projects/libcxxabi : # 8. Create new tarball from the resulting source tree > Move this description to package-llvm.sh. Done -- To view, visit http://gerrit.cloudera.org:8080/7069 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I64f98bb56d2510ba03ef5ea477a4d7bb4b48c555 Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Dan Burkert <danburk...@apache.org> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Dan Burkert <danburk...@apache.org> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-HasComments: Yes
