Todd Lipcon has posted comments on this change. Change subject: [ExternalDaemon] return non-OK if no process to pause/resume ......................................................................
Patch Set 2: (3 comments) http://gerrit.cloudera.org:8080/#/c/7092/2/src/kudu/integration-tests/external_mini_cluster.cc File src/kudu/integration-tests/external_mini_cluster.cc: PS2, Line 827: NotFound maybe IllegalState is more appropriate? Line 839: return Status::NotFound(Substitute( same PS2, Line 1108: const Status s = daemon_->Resume(); : if (!s.ok()) { : LOG(WARNING) << "Could not resume external daemon: " << s.ToString(); : use WARN_NOT_OK here? -- To view, visit http://gerrit.cloudera.org:8080/7092 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ibce641a29ffc43391f54c6a8aacf6ba91ae93ae9 Gerrit-PatchSet: 2 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Alexey Serbin <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: David Ribeiro Alves <[email protected]> Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-HasComments: Yes
