Adar Dembo has posted comments on this change. Change subject: disk failure: make DataDirManager failure-aware ......................................................................
Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/7028/2/src/kudu/fs/data_dirs.cc File src/kudu/fs/data_dirs.cc: Line 88: METRIC_DEFINE_gauge_uint64(server, data_dirs_failed, Nit: "failed" sorts ahead of "full" (update elsewhere if needed). PS2, Line 610: set<string>() Can you return {} instead? -- To view, visit http://gerrit.cloudera.org:8080/7028 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iee212793152de5de5198751d649ab34fb97f6aa2 Gerrit-PatchSet: 2 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Andrew Wong <aw...@cloudera.com> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com> Gerrit-Reviewer: David Ribeiro Alves <davidral...@gmail.com> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-HasComments: Yes
