David Ribeiro Alves has posted comments on this change. Change subject: codegen: fix regression in inlining after LLVM 4.0 upgrade ......................................................................
Patch Set 1: (3 comments) http://gerrit.cloudera.org:8080/#/c/7099/1//COMMIT_MSG Commit Message: PS1, Line 17: due to be very small wording PS1, Line 50: I0606 16:53:51.573541 48403 memrowset-test.cc:446] Time spent Scanning rows where all are committed: real 0.302s user 0.302s sys 0.000s curious, how do these compare to the numbers before the regression? http://gerrit.cloudera.org:8080/#/c/7099/1/src/kudu/codegen/CMakeLists.txt File src/kudu/codegen/CMakeLists.txt: PS1, Line 120: Disable built-in LLVM passes which would add 'noinline' attributes to all : # standalone functions. is there a way to disable that specific no-inlining pass? are we leaving present or future perf on the table by not allowing this in general because of one faulty optimization pass? -- To view, visit http://gerrit.cloudera.org:8080/7099 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7e449df80e5cd02b9ce2dbf4daa5cf8151007dcf Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Todd Lipcon <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: David Ribeiro Alves <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-HasComments: Yes
