David Ribeiro Alves has posted comments on this change. Change subject: disk failure: handle EIOs on I/O to blocks ......................................................................
Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/7030/3/src/kudu/cfile/cfile_reader.cc File src/kudu/cfile/cfile_reader.cc: PS3, Line 184: KUDU_RETURN_OR_HANDLE(EIO, block_->Read(0, &mal), block_->HandleEIO()); don't quite follow this. if the read fails with an EIO will this continue to do anything? doesn't seem like it should but maybe I'm misunderstanding. also if the block knows how to handle EIOs why does this need to make an explicit call? like I said in the other patch, give me a bit to come up with a suggestion. -- To view, visit http://gerrit.cloudera.org:8080/7030 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia03bfb711a1b022d7516f4adb37fe9fb28ec949c Gerrit-PatchSet: 3 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Andrew Wong <aw...@cloudera.com> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: David Ribeiro Alves <davidral...@gmail.com> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-HasComments: Yes
