Adar Dembo has posted comments on this change. Change subject: Tweak build-and-test.sh to fix spark1 test failures ......................................................................
Patch Set 1: (4 comments) http://gerrit.cloudera.org:8080/#/c/7129/1//COMMIT_MSG Commit Message: Line 12: the kudu-spark target dir. I've also snuck in a change to add the -B Please also note the change to no longer build javadocs. http://gerrit.cloudera.org:8080/#/c/7129/1/build-support/jenkins/build-and-test.sh File build-support/jenkins/build-and-test.sh: Line 358: MVN_FLAGS="$MVN_FLAGS -B -Dsurefire.rerunFailingTestsCount=3 -Dfailsafe.rerunFailingTestsCount=3 -Dmaven.javadoc.skip" Could you spread this out line-by-line? Makes it easier to add new flags and do a visual diff: MVN_FLAGS="$MVN_FLAGS -B" MVN_FLAGS="$MVN_FLAGS -Dsurefire..." ... Line 363: # If there are no failure, rerun the build with Spark 1.x with Scala 2.10. "If there are no failure" isn't grammatically correct. Line 365: else if ! mvn $MVN_FLAGS -Dtest="org.apache.kudu.spark.*.*" -Pspark_2.10 clean verify ; then Need to use elif in bash. -- To view, visit http://gerrit.cloudera.org:8080/7129 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I92fb0c05a9da65e1a41eb9017050cd8f957ce3a8 Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Dan Burkert <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Grant Henke <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-HasComments: Yes
