Todd Lipcon has posted comments on this change. Change subject: Fix misc-move-const-arg tidy warnings ......................................................................
Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/7133/1/src/kudu/benchmarks/tpch/tpch_real_world.cc File src/kudu/benchmarks/tpch/tpch_real_world.cc: Line 177: cluster_.reset(new ExternalMiniCluster(opts)); > hrm, that's a good question. Let me fiddle with it a bit to see if I can un figured this out. Since ExternalMiniCluster defines a destructor, it doesn't auto-generate the default move constructor, and thus this won't move despite a std::move(). So, I think the fix is probably to stop implementing a destructor, so that it generates default move ctor. -- To view, visit http://gerrit.cloudera.org:8080/7133 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3b78afde183061112d69e422ca81b88c3fa2492d Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Todd Lipcon <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-HasComments: Yes
