Hao Hao has posted comments on this change. Change subject: WIP KUDU-1943: Add BlockTransaction to Block Manager ......................................................................
Patch Set 2: (5 comments) http://gerrit.cloudera.org:8080/#/c/7207/1/src/kudu/fs/block_manager.h File src/kudu/fs/block_manager.h: Line 318: // TODO(Hao): complete CommitDeletes(). > warning: missing username/bug in TODO [google-readability-todo] Done http://gerrit.cloudera.org:8080/#/c/7207/1/src/kudu/fs/log_block_manager.cc File src/kudu/fs/log_block_manager.cc: Line 374: // Returns a block's length aligned to the nearest filesystem block size. > warning: parameter 'block_offset' is const-qualified in the function declar Done Line 375: int64_t fs_aligned_length(int64_t block_offset, > warning: parameter 'block_length' is const-qualified in the function declar Done Line 379: // of a fully written block. > warning: parameter 'block_length' is const-qualified in the function declar Done Line 379: // of a fully written block. > warning: parameter 'block_offset' is const-qualified in the function declar Done -- To view, visit http://gerrit.cloudera.org:8080/7207 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I01f3ed830cc1f86d7bb8a66b2f780914a88884bd Gerrit-PatchSet: 2 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Hao Hao <hao....@cloudera.com> Gerrit-Reviewer: Dan Burkert <danburk...@apache.org> Gerrit-Reviewer: Hao Hao <hao....@cloudera.com> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Tidy Bot Gerrit-HasComments: Yes
