Adar Dembo has posted comments on this change. Change subject: kserver: introduce KuduServer class ......................................................................
Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/7239/1/src/kudu/kserver/kserver.h File src/kudu/kserver/kserver.h: Line 49: Status Init(); > should these methods be virtual and override? Yeah. I don't think it's a huge deal (since the instances are always of type Master/TabletServer and we explicitly call ServerBase::Foo and KuduServer:Foo), but it's certainly confusing. -- To view, visit http://gerrit.cloudera.org:8080/7239 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I41ffd09ce46d9d744aa25343cec77b7a33b88563 Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: David Ribeiro Alves <davidral...@gmail.com> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-HasComments: Yes
