Adar Dembo has posted comments on this change.

Change subject: [java] Replace interface-annotations with Apache Yetus 
annotations
......................................................................


Patch Set 6:

(4 comments)

http://gerrit.cloudera.org:8080/#/c/7235/6//COMMIT_MSG
Commit Message:

Could you add some notes here about the backwards compatibility implications? I 
think we discussed this on Slack but it would be good to capture it in the git 
commit too.


http://gerrit.cloudera.org:8080/#/c/7235/6/java/kudu-client/pom.xml
File java/kudu-client/pom.xml:

Line 37:             <scope>compile</scope>
Isn't this the default scope? Can it be omitted?


http://gerrit.cloudera.org:8080/#/c/7235/6/java/kudu-jepsen/pom.xml
File java/kudu-jepsen/pom.xml:

Line 104:             <scope>compile</scope>
Likewise.


http://gerrit.cloudera.org:8080/#/c/7235/6/java/kudu-spark/pom.xml
File java/kudu-spark/pom.xml:

Line 68:             <scope>compile</scope>
And here too.


-- 
To view, visit http://gerrit.cloudera.org:8080/7235
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I860e59f497d96f507d5a2b0ea517f9f8d0794dac
Gerrit-PatchSet: 6
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Will Berkeley <wdberke...@gmail.com>
Gerrit-Reviewer: Adar Dembo <a...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <danburk...@apache.org>
Gerrit-Reviewer: Jean-Daniel Cryans <jdcry...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-HasComments: Yes

Reply via email to