Adar Dembo has posted comments on this change. Change subject: Rename MiniClusterBase to MiniCluster ......................................................................
Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/7273/1/src/kudu/integration-tests/mini_cluster.h File src/kudu/integration-tests/mini_cluster.h: PS1, Line 47: MiniCluster > whats the motivation behind the rename? the base suffix usually refers to a I'm also wondering the same thing (e.g. ServerBase, though that's not an abstract class per se). -- To view, visit http://gerrit.cloudera.org:8080/7273 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I40273d6ca7ac5fdc4cf2a6de374d374fe86cbf36 Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Mike Percy <mpe...@apache.org> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: David Ribeiro Alves <davidral...@gmail.com> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-HasComments: Yes