Mike Percy has posted comments on this change. Change subject: ConsensusMetadata::Create() should not overwrite an existing file ......................................................................
Patch Set 1: (3 comments) http://gerrit.cloudera.org:8080/#/c/7190/1//COMMIT_MSG Commit Message: PS1, Line 7: ConsensusMetadata::Create() should not overwrite an existing file > why? (please spell it out in the commit message) Done http://gerrit.cloudera.org:8080/#/c/7190/1/src/kudu/consensus/consensus_meta-test.cc File src/kudu/consensus/consensus_meta-test.cc: PS1, Line 111: ); > oh, "speed read" (i.e. skimmed) too fast. agreed, my bad. Done http://gerrit.cloudera.org:8080/#/c/7190/1/src/kudu/consensus/consensus_meta.h File src/kudu/consensus/consensus_meta.h: PS1, Line 60: enum FlushMode { : OVERWRITE, : NO_OVERWRITE : }; > docs Done -- To view, visit http://gerrit.cloudera.org:8080/7190 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0bfef1ae86a7d2c162095a76bb184a9c18dc69a7 Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Mike Percy <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: David Ribeiro Alves <[email protected]> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy <[email protected]> Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-HasComments: Yes
