Todd Lipcon has posted comments on this change. Change subject: disk failure: make DataDirManager failure-aware ......................................................................
Patch Set 11: (3 comments) http://gerrit.cloudera.org:8080/#/c/7028/11/src/kudu/fs/data_dirs.cc File src/kudu/fs/data_dirs.cc: PS11, Line 471: static_cast<int>(data_dirs_.size() maybe put the cast around size() instead of the result of the subtraction? Otherwise this unsigned subtraction could underflow? PS11, Line 622: if (error_message.empty()) { missing a '!'? Line 632: return ContainsKey(failed_data_dirs_, uuid_idx); can we DCHECK_LT(uuid_idx, data_dirs_.size()) or something? especially with these unsigned ints floating around I think it's worth trying to guard against underflows -- To view, visit http://gerrit.cloudera.org:8080/7028 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iee212793152de5de5198751d649ab34fb97f6aa2 Gerrit-PatchSet: 11 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Andrew Wong <aw...@cloudera.com> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com> Gerrit-Reviewer: David Ribeiro Alves <davidral...@gmail.com> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-HasComments: Yes
