Adar Dembo has posted comments on this change. Change subject: KUDU-1863: improve overall safety of graceful server shutdown ......................................................................
Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/7183/2//COMMIT_MSG Commit Message: Line 31: generic subsystems. > That's a good question. I didn't encounter any issues, but that's because a It turns out that this isn't doable either, at least not right now. The Webserver subsystem (and squeasel) doesn't provide a mechanism to stop receiving inbound HTTP requests without also destroying state (be it in-memory state or bound sockets). Once the state is gone, the tserver heartbeater threads fail in SetupRegistration(). So I'm going to roll this part of the change back (and update the commit message accordingly). -- To view, visit http://gerrit.cloudera.org:8080/7183 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ibbda29dd471e4dc1a8cb4f472cc456ccdb1e48cc Gerrit-PatchSet: 2 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: David Ribeiro Alves <davidral...@gmail.com> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-HasComments: Yes
