Alexey Serbin has posted comments on this change. Change subject: [java] KUDU-2013 re-acquire authn token if expired ......................................................................
Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/7250/1/java/kudu-client/src/main/java/org/apache/kudu/client/Connection.java File java/kudu-client/src/main/java/org/apache/kudu/client/Connection.java: Line 668: TO_BE_RENEGOTIATED, // The connection negotiation has failed and has to be be re-negotiated. > Yep, ideally it would be nice to have just DISCONNECTED state and recycle d An update: after looking at how to avoid re-connecting a connection, I came into conclusion this might be too cumbersome. If not allowing the TO_BE_RENEGOTIATED state and further re-connecting, it would require calling status errbacks for all the enqueued RPC messages after a new authentication token is acquired (we cannot silently drop the connection which is in TO_BE_RENEGOTIATED phase because there are enqueued messages). So, this would lead the upper-level code to retry corresponding RPCs, one-at-a-time (basically, that's about finding or establishing a new connection via the connection cache and then creating new copies of the messages in the wire format to be put into the queuedMessages member of other Connection object). Do we want to go that way? -- To view, visit http://gerrit.cloudera.org:8080/7250 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0be620629c9a8345ecd5e5679c80ee76ca4eaa57 Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Dan Burkert <danburk...@apache.org> Gerrit-Reviewer: Jean-Daniel Cryans <jdcry...@apache.org> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-Reviewer: Will Berkeley <wdberke...@gmail.com> Gerrit-HasComments: Yes
