Mike Percy has posted comments on this change. Change subject: Create ConsensusMetadataManager ......................................................................
Patch Set 2: (4 comments) http://gerrit.cloudera.org:8080/#/c/7191/7/src/kudu/consensus/consensus_meta_manager.cc File src/kudu/consensus/consensus_meta_manager.cc: Line 44 > in that case, if a load races with a create, can it see partially written d No, they are mutexed in this implementation. However I see that this impl is confusing for reviewers. So I am going to weaken the semantics a bit and simplify the impl a lot. PS7, Line 51: > nit: can't you just lock in CancelOpInProgress? Good point. But I guess it's moot, I'll try to simplify. http://gerrit.cloudera.org:8080/#/c/7191/2/src/kudu/tablet/tablet_bootstrap.cc File src/kudu/tablet/tablet_bootstrap.cc: PS2, Line 169: meta > maybe just on the public method then. Not excited about this because it's a slippery slope. But OK - I'll do it in this file. A separate patch makes more sense for a pervasive rename. http://gerrit.cloudera.org:8080/#/c/7191/2/src/kudu/tserver/ts_tablet_manager.cc File src/kudu/tserver/ts_tablet_manager.cc: PS2, Line 1067: const scoped_refptr<consensus::ConsensusMetadataService>& > yeah, but the caller might then think that this method increases the refcou I don't see a problem with that. This method only takes a constref and returns when it's done so the caller can drop the ref after this method returns. From my perspective it would be significantly more confusing if we passed a bare ptr here. -- To view, visit http://gerrit.cloudera.org:8080/7191 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia30c05dd0feec2b7530205f4d17dfc079a1c3451 Gerrit-PatchSet: 2 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Mike Percy <mpe...@apache.org> Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: David Ribeiro Alves <davidral...@gmail.com> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy <mpe...@apache.org> Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-HasComments: Yes
