Mike Percy has posted comments on this change. Change subject: mini cluster: Test infrastructure improvements ......................................................................
Patch Set 4: (1 comment) http://gerrit.cloudera.org:8080/#/c/6959/4/src/kudu/integration-tests/delete_tablet-itest.cc File src/kudu/integration-tests/delete_tablet-itest.cc: PS4, Line 49: ts_map_[mts->uuid()] > A small nit which I didn't notice on the first pass. Feel free to ignore: I'm open to fixing this and eventually I want to get rid of TServerDetails and replace it with a base class MiniTabletServer that works for both internal and external mini clusters. But I don't want to do all of that stuff as part of this patch, if that makes sense. -- To view, visit http://gerrit.cloudera.org:8080/6959 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6bc6a04b113e59243fb788fec15b9935c3dcf069 Gerrit-PatchSet: 4 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Mike Percy <mpe...@apache.org> Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: David Ribeiro Alves <davidral...@gmail.com> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy <mpe...@apache.org> Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-HasComments: Yes