Alexey Serbin has posted comments on this change. Change subject: [java] separating Connection ......................................................................
Patch Set 21: (1 comment) http://gerrit.cloudera.org:8080/#/c/7146/21/java/kudu-client/src/main/java/org/apache/kudu/client/AsyncKuduClient.java File java/kudu-client/src/main/java/org/apache/kudu/client/AsyncKuduClient.java: Line 731: String.format("No information on servers hosting tablet %s, will retry later", > does this take care of triggering it to get looked up? Is this path covered As I understand, the lookup will be performed by the delayed sendRpcToTablet() method call: that's in the very end of the AsyncKuduClient.sendRpcToTablet() implementation block. I think the path is covered by existing tests, e.g. ITFaultTolerantScanner and ITNonFaultTolerantScanner. At least, when I ran them, I saw they came through this point. Do you think we need to add some dedicated test here as well? -- To view, visit http://gerrit.cloudera.org:8080/7146 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id4ac81d9454631e7501c31576c24f85e968bb871 Gerrit-PatchSet: 21 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Dan Burkert <danburk...@apache.org> Gerrit-Reviewer: Jean-Daniel Cryans <jdcry...@apache.org> Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-HasComments: Yes