Alexey Serbin has posted comments on this change.

Change subject: [tests] fix on client_samples
......................................................................


Patch Set 1:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/7359/1/src/kudu/client/samples/sample.cc
File src/kudu/client/samples/sample.cc:

Line 110:       .num_replicas(1)
> woops, that's some remnants from my earlier experements.  Good catch -- I'l
Yep, that's exactly the thing which would allow the test to run with some other 
master and tserver running at default ports and listening on all available 
interfaces which the previous revision of the script would not catch.


-- 
To view, visit http://gerrit.cloudera.org:8080/7359
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I5cbaa01313cdf49117bbf8e70e7a22a35fe47021
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Alexey Serbin <[email protected]>
Gerrit-Reviewer: Alexey Serbin <[email protected]>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <[email protected]>
Gerrit-HasComments: Yes

Reply via email to