Alexey Serbin has posted comments on this change. Change subject: Create ConsensusMetadataManager ......................................................................
Patch Set 18: Code-Review+2 (3 comments) Probably you want to get more feedback from David and Todd, but so far it LGTM. http://gerrit.cloudera.org:8080/#/c/7191/17/src/kudu/consensus/consensus_meta_manager-stress-test.cc File src/kudu/consensus/consensus_meta_manager-stress-test.cc: PS17, Line 98: kNumOpsPerThread = 1000 > Yeah it's pretty fast: ok, this is great. PS17, Line 187: > Yeah but that is equivalent to load(std::memory_order_seq_cst) which I beli All right, if you want it here because of that, that's OK. I just thought it might be easier to read without memory order spec since performance is not such an issue here. http://gerrit.cloudera.org:8080/#/c/7191/17/src/kudu/consensus/consensus_meta_manager.cc File src/kudu/consensus/consensus_meta_manager.cc: PS17, Line 50: DCHECK(cmeta_out); > I thought about it but it wasn't needed by any existing code. Most of the t That's fine -- let's keep it then. -- To view, visit http://gerrit.cloudera.org:8080/7191 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia30c05dd0feec2b7530205f4d17dfc079a1c3451 Gerrit-PatchSet: 18 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Mike Percy <mpe...@apache.org> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: David Ribeiro Alves <davidral...@gmail.com> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Mike Percy <mpe...@apache.org> Gerrit-Reviewer: Tidy Bot Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-HasComments: Yes
