Mike Percy has posted comments on this change.

Change subject: consensus: Get rid of RaftConsensus::Create()
......................................................................


Patch Set 8:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/7192/8/src/kudu/consensus/raft_consensus_quorum-test.cc
File src/kudu/consensus/raft_consensus_quorum-test.cc:

PS8, Line 161: for (int i = 0; i < config_.peers_size(); i++) {
             :       scoped_refptr<ConsensusMetadata> cmeta;
             :       RETURN_NOT_OK(cmeta_managers_[i]
> Does it make sense to add
Done


-- 
To view, visit http://gerrit.cloudera.org:8080/7192
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic28fb8fe64cd62d290cea1de22c4ba9dd1743a4e
Gerrit-PatchSet: 8
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Mike Percy <mpe...@apache.org>
Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com>
Gerrit-Reviewer: David Ribeiro Alves <davidral...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mpe...@apache.org>
Gerrit-Reviewer: Tidy Bot
Gerrit-HasComments: Yes

Reply via email to