Michael Ho has posted comments on this change. Change subject: KUDU-2065: Support cancellation for outbound RPC call ......................................................................
Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/7455/1/src/kudu/rpc/outbound_call.cc File src/kudu/rpc/outbound_call.cc: PS1, Line 377: delete [] header_buf_.release(); : sidecars_.clear(); Consider doing the same thing for other Set*() functions or moving it to CallCallback() ? May also wanna set controller_ field to null as it may be freed by the callback. -- To view, visit http://gerrit.cloudera.org:8080/7455 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iaf53c5b113de10d573bd32fb9b2293572e806fbf Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Michael Ho <k...@cloudera.com> Gerrit-Reviewer: Michael Ho <k...@cloudera.com> Gerrit-HasComments: Yes
