Todd Lipcon has posted comments on this change. Change subject: Upgrade to cmake 3.9.0 ......................................................................
Patch Set 1: Yea the main reason is that it fixes false dependencies on compilation between modules due to this bug I reported 2 years ago: https://cmake.org/Bug/view.php?id=15555 Here are some timings building kudu on an 88-core box using ninja: hot ccache (no real difference) ----------- cmake 3.6: 151.56user 39.47system 0:12.58elapsed 1518%CPU (0avgtext+0avgdata 271912maxresident)k 256inputs+4433488outputs (1major+6657138minor)pagefaults 0swaps cmake 3.9: 158.52user 38.55system 0:12.78elapsed 1541%CPU (0avgtext+0avgdata 271732maxresident)k 0inputs+4464520outputs (0major+6715240minor)pagefaults 0swaps cold ccache (big speedup with cmake 3.9) ------------ cmake 3.6: 2742.24user 192.17system 1:31.36elapsed 3211%CPU (0avgtext+0avgdata 466932maxresident)k 0inputs+14842640outputs (0major+58352987minor)pagefaults 0swaps cmake 3.9: 3461.34user 219.52system 0:57.90elapsed 6356%CPU (0avgtext+0avgdata 471408maxresident)k 0inputs+14838200outputs (0major+60222932minor)pagefaults 0swaps -- To view, visit http://gerrit.cloudera.org:8080/7460 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6e5504bcb136e70a5e5c83ee95c98df3cad4d3bd Gerrit-PatchSet: 1 Gerrit-Project: kudu Gerrit-Branch: master Gerrit-Owner: Todd Lipcon <t...@apache.org> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Dan Burkert <danburk...@apache.org> Gerrit-Reviewer: Kudu Jenkins Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-HasComments: No
